Skip unknown kty in JWKSet import per RFC 7517 §5 - #388
Open
rjeffman wants to merge 1 commit into
Open
Conversation
RFC 7517 §5 states that implementations SHOULD ignore JWKs with unrecognized kty values. Previously, a single unknown kty would abort the entire keyset import, breaking consumers when providers add post-quantum or other novel key types to their JWKS endpoints. Fixes: latchset#385 Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Rafael Guterres Jeffman <rjeffman@redhat.com>
|
could you please restart checks? |
Collaborator
Author
|
@eirnym all checks passed. Do you agree on merging the changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 7517 §5 states that implementations SHOULD ignore JWKs with unrecognized kty values. Previously, a single unknown kty would abort the entire keyset import, breaking consumers when providers add post-quantum or other novel key types to their JWKS endpoints.
Fixes: #385
Assisted-by: Claude Opus 4.6 (1M context) noreply@anthropic.com