fix(codegen): drop module prefix from operation command names - #103
Merged
Conversation
Strip leading operationId segments that match the module name so commands like console_listApps become list-apps instead of console-list-apps. Signed-off-by: samzong <samzong.lu@gmail.com> ## Considered and deferred - internal/codegen/normalize/normalize.go:267 [BOT-NIT]: Missing parentheses around the && clause is less readable but Go precedence is correct; not changing.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49c3a36dbc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
operationIdsegment when it matches the module name (in addition to the group name), so names likeconsole_listAppsbecomelist-appsinstead ofconsole-list-apps.create_chunk/update_chunk/delete_chunk) onto one command name.Verification
go test ./internal/codegen/normalize/ -count=1Compatibility
Generated command
Usenames may shorten when anoperationIdis prefixed with the module name. Group-prefix behavior is unchanged. Catalog schema, auth, body, and output format are unaffected.Checklist
internal/generated/,.cache/, and ad-hocskills/<cli-name>/directories is not committed.Considered and deferred