fix: repair make doctor on a fresh install - #34
Merged
Conversation
- Quote CORS_ALLOW_ORIGIN in .env.dist: the unquoted parentheses make scripts/doctor.sh fail with a shell syntax error when it sources .env. - Probe /healthz instead of /api/health: /api/* requires a JWT and returns 401, so the check reported the backend unreachable when it was healthy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #
Changes
Type of Change
Checklist
make testpasses (unit + integration)make stanpasses (PHPStan)make cs-fixerappliedScreenshots (if applicable)