ao-cli release/0.7: 24 daemon-runtime tests red on rc.8 (workflow-config 'unknown phase requirements' fixtures) - #344
Conversation
…fig 'unknown phase requirements' fixtures)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
VERDICT: CHANGES REQUESTED
crates/orchestrator-daemon-runtime/src/dispatch/process_manager.rs:workflow_skills_env_payload test setup— the added call remains in a form rejected by the repository formatter:let _seam = orchestrator_config::workflow_config::config_source_client::install_yaml_config_source_base(, and bothrustfmtjobs fail on headce6116803fbe80442db9df9c3b44a78ca11e4385. REQUIRED CHANGE: runcargo fmt --allat the workspace root and commit every resulting formatting-only edit in the seven touched files; do not alter test behavior. Verify withcargo fmt --all -- --checkand confirm the GitHubrustfmtcheck completes successfully.
The substantive fixture repair is well targeted: it registers the phase catalog entries now required by validation, installs the YAML config-source test seam where runtime resolution needs it, updates the flavor stub to the current config-source contract, and stays on the requested release/0.7 base. Workspace compilation, clippy, dependency guardrail, Vercel, and smoke checks are green.
…fig 'unknown phase requirements' fixtures)
There was a problem hiding this comment.
VERDICT: APPROVE
No blocking findings. The update is correctly based on release/0.7, keeps the change focused on repairing stale daemon-runtime test fixtures, registers the phase-catalog entries required by the workflows under test, and installs scoped YAML config-source seams where the tests need the file-backed configuration. The follow-up also resolves the prior formatting blocker. Current head d91810a2adb4d3606d72fbd7c848d91840a46149 is green across rustfmt, workspace cargo-check, clippy, dependency guardrail, smoke-help, and Vercel checks.
What is good: the production behavior is left unchanged; the added dependency is dev-only; guard lifetimes are explicit; and the fixture changes directly match the configuration validation failures described by TASK-287.
f7482a8
into
release/0.7
Automated change for TASK-287 via the Animus coding workflow (deterministic git on a shared ephemeral node).