Skip to content

TASK-971: route workflow reads through typed services - #359

Merged
Shooksie merged 1 commit into
mainfrom
audit/task-971-workflow-services
Jul 29, 2026
Merged

TASK-971: route workflow reads through typed services#359
Shooksie merged 1 commit into
mainfrom
audit/task-971-workflow-services

Conversation

@Shooksie

Copy link
Copy Markdown
Contributor

Summary

  • route nine workflow read/model MCP operations through typed in-process application services shared with CLI JSON paths
  • preserve actor ownership filtering before pagination and typed workflow projections
  • expose decisions and checkpoints on actor-bound MCP servers now that both enforce persisted workflow ownership
  • retain the daemon control-wire optimization for direct CLI reads and leave runner execution, destructive controls, and config mutations for separate slices
  • remove the now-unused generic MCP list subprocess helper and workflow-list argv builder

Migrated tools:

  • animus.workflow.list
  • animus.workflow.get
  • animus.workflow.decisions
  • animus.workflow.checkpoints.list
  • animus.workflow.phases.list
  • animus.workflow.phases.get
  • animus.workflow.definitions.list
  • animus.workflow.config.get
  • animus.workflow.config.validate

Verification

  • cargo check -p orchestrator-cli --tests
  • cargo clippy -p orchestrator-cli --tests -- -D warnings
  • cargo test -p orchestrator-cli workflow_inproc -- --test-threads=1 (2 passed)
  • cargo test -p orchestrator-cli services::operations::ops_workflow::tests -- --test-threads=1 (13 passed)
  • cargo test -p orchestrator-cli services::operations::ops_mcp::tests -- --test-threads=1 (76 passed)
  • cargo test -p orchestrator-cli --bin animus --quiet -- --test-threads=1 (1,425 passed)
  • cargo fmt --all -- --check
  • git diff --check

TASK-971 scope

This is the workflow read/model increment. Workflow run/execute/batch, pause/resume/cancel, manual phase decisions, and config mutations remain, followed by agent, output, cost, environment, and selected daemon/config families.

@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
animus-docs Ready Ready Preview, Comment Jul 29, 2026 2:55pm

Request Review

@Shooksie
Shooksie marked this pull request as ready for review July 29, 2026 14:58
@Shooksie
Shooksie merged commit 635fec4 into main Jul 29, 2026
14 checks passed
@Shooksie
Shooksie deleted the audit/task-971-workflow-services branch July 29, 2026 14:58

@animus-launchapp-gitprovider animus-launchapp-gitprovider Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERDICT: APPROVE

No blocking findings. The workflow read/model MCP surface is routed through typed in-process application functions without broadening the mutation/execution scope. Actor-bound list/get/decision/checkpoint reads preserve ownership filtering before pagination, invalid filters retain typed invalid_input errors, and the CLI JSON paths share the same service functions while human-readable paths remain intact. The removal of the obsolete argv/list subprocess helpers is appropriately limited to the migrated operations.

Verification evidence is strong: both CI matrices are green for cargo-check, Clippy, rustfmt, docs sync, dependency guardrails, and smoke-help. The focused and full-suite results reported in the PR are consistent with the change. Good separation of the application boundary in workflow_inproc.rs, and good retention of the daemon control-wire optimization and unrelated write/control paths for later slices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant