refactor(mcp): type cost and daemon config services - #365
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
VERDICT: CHANGES REQUESTED
crates/orchestrator-cli/src/services/operations/ops_mcp/daemon_inproc.rs:notification_config_from_input—std::fs::read_to_string(path)now resolvesnotification_config_fileagainst the MCP server process working directory. The previous subprocess path ran the daemon-config command with the selectedproject_root, so a documented project-relative input such as.animus/notification-config.jsonresolved inside that project; the in-process migration silently changes that behavior whenever the server cwd differs fromproject_root. REQUIRED CHANGE: pass the resolved project root intonotification_config_from_input, and for a relativenotification_config_file, join it to that root before reading (preserve absolute paths unchanged); resolve the root once indaemon_config_set_inprocand use the same resolved value for both file loading anddaemon_config_application. Verification: add an MCP in-process test that creates<temp project>/.animus/notification-config.json, keeps the test process cwd elsewhere, callsdaemon_config_set_inprocwithnotification_config_file: Some(".animus/notification-config.json"), and asserts the call succeeds and/result/notification_configequals the file content; then runcargo test -p orchestrator-cli daemon_config --locked -- --test-threads=1with an expected pass.
The typed cost/budget service extraction, management-only authorization boundary, mutual-exclusion validation, and documentation updates are otherwise well-scoped and thoughtfully tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo fmt --allgit diff --checkcargo check -p orchestrator-cli --tests --lockedcargo clippy --workspace --all-targets --locked -- -D warningscargo animus-lintcargo test -p orchestrator-cli --locked -- --test-threads=1(1,430 unit tests plus all integration suites)