fix: debug event timezone handling #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: implement AllFlags
cwaldren-ld
commented
May 11, 2023
| if (!event.require_full_event) { | ||
| return; | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
bugfix: debug event emit logic shouldn't be gated by require_full_event (which right now is equivalent to the flag's track_events prop.)
cwaldren-ld
commented
May 11, 2023
| std::istringstream string_stream(datetime); | ||
| string_stream.imbue(std::locale("en_US.utf-8")); | ||
| string_stream >> std::get_time(&gmt_tm, "%a, %d %b %Y %H:%M:%S GMT"); | ||
| if (string_stream.fail()) { |
Contributor
Author
There was a problem hiding this comment.
Bugfix: simply parsing using std::get_time followed by mktime gives us a std::chrono::system_clock::time_point in local time. We need to actually compute the offset and subtract it out.
This code is just so painful. C++20 has a parse method which might help, or we can import a 3rd party library..
kinyoklion
approved these changes
May 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the handling of timezones when parsing the
Dateheader from HTTP responses.The problem was that the date given by servers is GMT, but code was interpreting that in the local host's timezone, leading to an 8 hour offset for me. Instead, we need to obtain the offset and subtract that out of the parsed result.