fix: send identify event on Client startup [contract-tests] #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
commented
May 10, 2023
| } else if (outbox_.Empty()) { | ||
| events.push_back(boost::json::value_from(summarizer_)); | ||
| } else if (events.empty()) { | ||
| return std::nullopt; |
Contributor
Author
There was a problem hiding this comment.
The bug was checking the outbox - which would always be empty in the else case since it was previously consumed on line 191.
cwaldren-ld
changed the title
cwaldren-ld
added a commit
that referenced
this pull request
May 11, 2023
* add SDK contract test server * allow for null evaluation reason when deserializing flag evaluation result * add github action for SDK tests * feat: implement AllFlags * fix: send identify event on client creation (#54) * have ContextFilter take the global private attributes by value * feat: add context build/parse routines [contract-tests] (#74)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
Identifycall toClient's constructor. Additionally, I fixed a logical error in the event sending code which was stopping some events from being delivered.