fix: ensure x-launchdarkly-tags is sent in event requests #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #205988: Include App Tags header on Events requests. |
cwaldren-ld
commented
Jun 8, 2023
| base_headers_.insert_or_assign(key, *value); | ||
| } else { | ||
| base_headers_.erase(key); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Could also have this just be a no-op if it's nullopt, but this also allows for removal without needing another API.
cwaldren-ld
force-pushed
the
cw/sc-205988/app-tags-all-requests
branch
from
8b244b6 to
599c72d
Compare
cwaldren-ld
force-pushed
the
cw/sc-205988/app-tags-all-requests
branch
from
599c72d to
200477d
Compare
kinyoklion
approved these changes
Jun 8, 2023
Merged
cwaldren-ld
added a commit
that referenced
this pull request
Jun 8, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-cpp-client: 3.0.1</summary> ## [3.0.1](launchdarkly-cpp-client-v3.0.0...launchdarkly-cpp-client-v3.0.1) (2023-06-08) ### Bug Fixes * enforce minimum polling interval of 5 minutes ([#144](#144)) ([2d60197](2d60197)) * ensure x-launchdarkly-tags is sent in event requests ([#145](#145)) ([c8b3aee](c8b3aee)) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-internal bumped from 0.1.3 to 0.1.4 * launchdarkly-cpp-common bumped from 0.3.0 to 0.3.1 </details> <details><summary>launchdarkly-cpp-common: 0.3.1</summary> ## [0.3.1](launchdarkly-cpp-common-v0.3.0...launchdarkly-cpp-common-v0.3.1) (2023-06-08) ### Bug Fixes * enforce minimum polling interval of 5 minutes ([#144](#144)) ([2d60197](2d60197)) * ensure x-launchdarkly-tags is sent in event requests ([#145](#145)) ([c8b3aee](c8b3aee)) </details> <details><summary>launchdarkly-cpp-internal: 0.1.4</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-common bumped from 0.3.0 to 0.3.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Casey Waldren <cwaldren@launchdarkly.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves application tag into HTTP Config, so it can propagate to data sources + event sender.