feat: flag data model #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…legates to std::optional<T> overloads
|
This pull request has been linked to Shortcut Story #207650: Flag data model. |
cwaldren-ld
force-pushed
the
cw/sc-207650/flag-data-model
branch
from
5a36e4b to
0158bf0
Compare
cwaldren-ld
force-pushed
the
cw/sc-207650/flag-data-model
branch
from
0158bf0 to
a0fbc31
Compare
cwaldren-ld
commented
Jun 30, 2023
|
|
||
| TEST(SDKDataSetTests, DeserializesZeroSegments) { | ||
| auto result = | ||
| boost::json::value_to<tl::expected<data_model::SDKDataSet, JsonError>>( |
Contributor
Author
There was a problem hiding this comment.
Some of these tests change in the (not yet issued) evaluator PR, due to slight changes in the data model. So if you notice some field that should be required (or the other way around), it might be fixed there.
Member
There was a problem hiding this comment.
Yeah, I am depending a bit on testing for that. Mainly checked conditions matched manes.
kinyoklion
reviewed
Jun 30, 2023
kinyoklion
reviewed
Jun 30, 2023
kinyoklion
reviewed
Jun 30, 2023
kinyoklion
reviewed
Jun 30, 2023
kinyoklion
reviewed
Jun 30, 2023
kinyoklion
reviewed
Jun 30, 2023
kinyoklion
approved these changes
Jun 30, 2023
kinyoklion
approved these changes
Jun 30, 2023
kinyoklion
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #153, extending the deserialization to flag data.
I've added to the
PARSE_FIELDmacro to handle the following cases:PARSE_FIELD. In other words, if the field is omitted or null, it will be filled in with a default value. Most common scenario.PARSE_FIELD_DEFAULT.optional:PARSE_CONDITIONAL_FIELD. For example, the value""wouldn't be a valid default for a unique key.PARSE_REQUIRED_FIELD. Usage of this should be rare; the test would be if the SDK is totally unable to function without this.To achieve this, I've made the
tag_invokes operate onexpected<optional<T>, JsonError's, instead ofexpected<T, JsonError.We could potentially revert that (and instead add a new enum case to
JsonError), but I figureoptionalis a good representation of null/omitted. I think I need to actually try removing it to determine if it results in a better API.One thing lacking is better error messages - we use kSchemaFailure everywhere but we now have the ability to report exactly what was missing/wrong type, etc.