feat: Implement basic in-memory store and change handling. #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dks-private into rlamb/data-store-arch
kinyoklion
commented
Jul 10, 2023
…arkly/cpp-sdks-private into rlamb/basic-store-implementation
kinyoklion
commented
Jul 10, 2023
kinyoklion
changed the title
kinyoklion
commented
Jul 10, 2023
Member
Author
|
|
cwaldren-ld
reviewed
Jul 11, 2023
Co-authored-by: Casey Waldren <cwaldren@launchdarkly.com>
…arkly/cpp-sdks-private into rlamb/basic-store-implementation
kinyoklion
commented
Jul 11, 2023
| sink_->Upsert(key, updated); | ||
| } | ||
|
|
||
| template <typename FlagOrSegment> |
Member
Author
There was a problem hiding this comment.
Still FlagOrSegment, because DataKind is a type, which is also used by this same method. Which is inconvenient.
cwaldren-ld
approved these changes
Jul 12, 2023
Contributor
cwaldren-ld
left a comment
cwaldren-ld
left a comment
There was a problem hiding this comment.
Couple lints on libs/server-sdk/src/data_store/dependency_tracker.cpp seem legit, but otherwise looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Move boost signal implementation to the internal library.