feat: context bucketing logic #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/bucketing
branch
from
f20419b to
a6fa27d
Compare
cwaldren-ld
force-pushed
the
cw/bucketing
branch
from
a6fa27d to
fce9efc
Compare
cwaldren-ld
force-pushed
the
cw/bucketing
branch
from
0f478b4 to
8e65ed2
Compare
kinyoklion
reviewed
Jul 13, 2023
|
|
||
| tl::expected<std::pair<ContextHashValue, RolloutKindLookup>, Error> Bucket( | ||
| Context const& context, | ||
| AttributeReference const& by_attr, |
Member
There was a problem hiding this comment.
I assume this is handled elsewhere, maybe in parsing, but when bucketBy is omitted entirely it is also "key".
Contributor
Author
There was a problem hiding this comment.
Yep, it's in the parser.
kinyoklion
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds bucketing logic to be used in evaluation engine.
Buckets are computed based on a hash value comprised of context attributes and prefixes derived from flag rules.