feat: add ContextKind type to data model #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e implementations
|
This pull request has been linked to Shortcut Story #209882: Make newtype for Kind in SDK data model. |
cwaldren-ld
commented
Jul 18, 2023
|
|
||
| namespace launchdarkly::data_model { | ||
|
|
||
| BOOST_STRONG_TYPEDEF(std::string, ContextKind); |
Contributor
Author
There was a problem hiding this comment.
It's nice that this exists, but it doesn't support move construction. I'll not worry about that until it proves worrisome (at which point we could roll our own macro easily.)
Member
There was a problem hiding this comment.
I suppose I could have used this in place of my tag types for flags/segments.
kinyoklion
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, context kind was an
std::string.The requirement that it not be an empty string was enforced by parent data model deserializers.
Now, we have a dedicated type-safe wrapper via
BOOST_STRONG_TYPEDEF. The customtag_invokeenforces the invariant so it's not possible to deserialize it inconsistently.