feat: Add expiration tracker. #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Jul 19, 2023
|
|
||
| namespace launchdarkly::server_side::data_store { | ||
|
|
||
| /** |
Member
Author
There was a problem hiding this comment.
Moved this to its own file so it could be re-used.
kinyoklion
commented
Jul 19, 2023
| @@ -0,0 +1,51 @@ | |||
| #pragma once | |||
Member
Author
There was a problem hiding this comment.
I scaffolded this file, but have not started on implementation.
kinyoklion
commented
Jul 19, 2023
| @@ -0,0 +1,37 @@ | |||
| #pragma once | |||
Member
Author
There was a problem hiding this comment.
Moved from dependency_tracker.hpp
kinyoklion
commented
Jul 19, 2023
| ExpirationTracker ttl_tracker_; | ||
| }; | ||
|
|
||
| } // namespace launchdarkly::server_side::data_store::persistent No newline at end of file |
Base automatically changed from
rlamb/add-persistent-core-interface
to
server-side
July 19, 2023 20:34
cwaldren-ld
reviewed
Jul 19, 2023
libs/server-sdk/src/data_store/persistent/expiration_tracker.hpp
Outdated
Show resolved
Hide resolved
cwaldren-ld
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an class for tracking expiration of "scoped" (DataKind) and "unscoped" (initialized) keys.
Time handling is left to the caller, and proactive eviction could be handled using the prune methods.
(If we end up wanting to encapsulate time, then we could add a layer that just calls
steady_clock::now()