feat: Serialize flags and segments. #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Jul 21, 2023
|
|
||
| Rollout() = default; | ||
| Rollout(std::vector<WeightedVariation>); | ||
| explicit Rollout(std::vector<WeightedVariation>); |
Member
Author
There was a problem hiding this comment.
To prevent infinite template recursion.
kinyoklion
commented
Jul 21, 2023
| data_model::Flag::Rollout::Kind const& kind) { | ||
| switch (kind) { | ||
| case Flag::Rollout::Kind::kUnrecognized: | ||
| // TODO: Should we be preserving the original string. |
Member
Author
There was a problem hiding this comment.
I imagine all strongly typed SDKs have this problem. So I will check some others. I am not super happy with it. (Though generally I don't like having to serialize, but it doesn't seem like there is any real alternative.)
kinyoklion
commented
Jul 21, 2023
| # Inform the test harness of test service's port. | ||
| test_service_port: ${{ env.TEST_SERVICE_PORT }} | ||
| extra_params: '-skip-from ./contract-tests/sdk-contract-tests/test-suppressions.txt' | ||
| build-test: |
Member
Author
There was a problem hiding this comment.
I changed the build names to it is easier to scan them in the PR checks.
cwaldren-ld
reviewed
Jul 21, 2023
| } | ||
| WriteMinimal(obj, "seed", rollout.seed); | ||
| if (rollout.bucketBy.Valid()) { | ||
| obj.emplace("bucketBy", rollout.bucketBy.RedactionName()); |
Contributor
There was a problem hiding this comment.
q: Should we be preserving this even if invalid?
Member
Author
There was a problem hiding this comment.
I am fine with preserving it, because here we will have some logical value retained. Probably.
cwaldren-ld
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.