feat: build server SDK in CI #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #206686: Build for mac/linux/windows in CI via Github Action. |
cwaldren-ld
commented
Aug 17, 2023
cwaldren-ld
commented
Aug 17, 2023
cwaldren-ld
commented
Aug 17, 2023
| // boost::bad_expression can be thrown by basic_regex when compiling a | ||
| // regular expression. | ||
| return false; | ||
| } catch (boost::regex_error) { |
Contributor
Author
There was a problem hiding this comment.
Turns out boost::bad_expression (above the fold) is actually a typedef for boost::regex_error.
Contributor
Author
|
Unit test failure is because I didn't address the timestamp precision stuff yet (found by Ryan a couple weeks ago.) |
cwaldren-ld
commented
Aug 17, 2023
| << context.Get("user", "attr") << " " << clause.op << " " | ||
| << clause.values << " should be " << param.expected; | ||
| << Value(clause.values) << " should be " << param.expected; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
ADL ambiguity error for operator<< thrown by MSVC. Hoping this resolves the ambiguity.
cwaldren-ld
commented
Aug 17, 2023
| TimestampTest{"2020-01-01T01:00:00.123456789+01:00", | ||
| "floor nanoseconds with offset", | ||
| BasicDate() + 123ms + 456us}, | ||
|
|
Contributor
Author
There was a problem hiding this comment.
These fail on some platforms because they do support > microsecond precision.
kinyoklion
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a build for the server SDK. The changes are mostly to fix compilation issues / warnings that I encountered.