fix: refactor Variation methods for correctness & clarity #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/sc-213848/refactor-variation-methods
branch
from
e13bc22 to
1cf9666
Compare
Base automatically changed from
cw/sc-213373/all-flags-state
to
cw/sc-206687/contract-tests
August 23, 2023 21:10
cwaldren-ld
changed the title
Implements prerequisite event recording, and fixes some bugs related to prereq event generation.
cwaldren-ld
commented
Aug 24, 2023
| @@ -1,111 +1,3 @@ | |||
| # SC-214431 | |||
Contributor
Author
There was a problem hiding this comment.
Woohoo! Just streaming issues left.
kinyoklion
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly refactors the
Variationinternal calls to be much easier to reason about. In the process, it fixes some broken behavior which is now reflected in the suppressions list.It also refactors event generation to use the
EventScope/EventFactorypattern found in other SDKs, such as Rust and Go.