feat: server-side C bindings #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #210041: SDK Client C bindings. |
cwaldren-ld
force-pushed
the
cw/sc-210041/server-client-bindings
branch
8 times, most recently
from
b6750d8 to
b5a3725
Compare
cwaldren-ld
commented
Aug 30, 2023
| LD_EXPORT(char*) | ||
| LDAllFlagsState_SerializeJSON(LDAllFlagsState state); | ||
|
|
||
| /** |
Contributor
Author
There was a problem hiding this comment.
This whole comment points to the danger of this kind of API.
Theoretically we could create a new typedef LDValueReference for these situations. And all the bindings. But it wouldn't have a binding for _Free. That'd prevent at least one error.
Another thing we could do is name this _ValueReference or something, rather than _Value.
cwaldren-ld
commented
Aug 30, 2023
| /** | ||
| * Enumeration of possible data source states. | ||
| */ | ||
| enum LDServerDataSourceStatus_State { |
Contributor
Author
There was a problem hiding this comment.
I admit these enums are quite ugly - but needed to rename so they don't clash with the client and can be independently changed.
Welcome to suggestions..
cwaldren-ld
force-pushed
the
cw/sc-210041/server-client-bindings
branch
from
a4638a2 to
409dbda
Compare
Adds a hello app for the server-side C bindings. Also adds an app that includes both SDKs, to ensure they can coexist without symbol clashes.
kinyoklion
reviewed
Aug 31, 2023
kinyoklion
reviewed
Aug 31, 2023
kinyoklion
reviewed
Aug 31, 2023
libs/common/include/launchdarkly/bindings/c/shared_function_argument_macro_definitions.h
Show resolved
Hide resolved
kinyoklion
reviewed
Aug 31, 2023
kinyoklion
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a set of C bindings for the server-side SDK.
Missing are flag notifier bindings, but this isn't implemented in the C++ side yet either.