Skip to content

feat: add DataSourceStatus() and plumb through IClient interface #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2023
Merged

feat: add DataSourceStatus() and plumb through IClient interface #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions libs/server-sdk/include/launchdarkly/server_side/client.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#include <launchdarkly/value.hpp>

#include <launchdarkly/server_side/all_flags_state.hpp>
#include <launchdarkly/server_side/data_source_status.hpp>

#include <chrono>
#include <future>
Expand Down Expand Up @@ -236,6 +237,13 @@ class IClient {
FlagKey const& key,
Value default_value) = 0;

/**
* Returns an interface which provides methods for subscribing to data
* source status.
* @return A data source status provider.
*/
virtual data_sources::IDataSourceStatusProvider& DataSourceStatus() = 0;

virtual ~IClient() = default;
IClient(IClient const& item) = delete;
IClient(IClient&& item) = delete;
Expand Down Expand Up @@ -320,6 +328,8 @@ class Client : public IClient {
FlagKey const& key,
Value default_value) override;

data_sources::IDataSourceStatusProvider& DataSourceStatus() override;

/**
* Returns the version of the SDK.
* @return String representing version of the SDK.
Expand Down
4 changes: 4 additions & 0 deletions libs/server-sdk/src/client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,10 @@ EvaluationDetail<Value> Client::JsonVariationDetail(Context const& ctx,
return client->JsonVariationDetail(ctx, key, std::move(default_value));
}

data_sources::IDataSourceStatusProvider& Client::DataSourceStatus() {
return client->DataSourceStatus();
}

char const* Client::Version() {
return kVersion;
}
Expand Down
9 changes: 5 additions & 4 deletions libs/server-sdk/src/client_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ ClientImpl::ClientImpl(Config config, std::string const& version)
ioc_(kAsioConcurrencyHint),
work_(boost::asio::make_work_guard(ioc_)),
memory_store_(),
status_manager_(),
data_source_(MakeDataSource(http_properties_,
config_,
ioc_.get_executor(),
Expand Down Expand Up @@ -441,10 +442,10 @@ Value ClientImpl::JsonVariation(Context const& ctx,
return *VariationInternal(ctx, key, default_value, events_default_);
}

// data_sources::IDataSourceStatusProvider& ClientImpl::DataSourceStatus() {
// return status_manager_;
// }
//
data_sources::IDataSourceStatusProvider& ClientImpl::DataSourceStatus() {
return status_manager_;
}

// flag_manager::IFlagNotifier& ClientImpl::FlagNotifier() {
// return flag_manager_.Notifier();
// }
Expand Down
6 changes: 4 additions & 2 deletions libs/server-sdk/src/client_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ class ClientImpl : public IClient {
FlagKey const& key,
Value default_value) override;

data_sources::IDataSourceStatusProvider& DataSourceStatus() override;

~ClientImpl();

std::future<bool> StartAsync() override;
Expand Down Expand Up @@ -172,15 +174,15 @@ class ClientImpl : public IClient {

data_store::MemoryStore memory_store_;

data_sources::DataSourceStatusManager status_manager_;

std::shared_ptr<::launchdarkly::data_sources::IDataSource> data_source_;

std::unique_ptr<events::IEventProcessor> event_processor_;

mutable std::mutex init_mutex_;
std::condition_variable init_waiter_;

data_sources::DataSourceStatusManager status_manager_;

evaluation::Evaluator evaluator_;

EventScope const events_default_;
Expand Down