fix: ensure flag updates go through data store updater #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/out-of-order-updates
branch
from
df736a4 to
97e55c9
Compare
cwaldren-ld
commented
Aug 31, 2023
| ioc_(kAsioConcurrencyHint), | ||
| work_(boost::asio::make_work_guard(ioc_)), | ||
| memory_store_(), | ||
| status_manager_(), |
Contributor
Author
There was a problem hiding this comment.
This is saying: store updates in the memory_store, and also read flag data from the memory_store.
kinyoklion
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hadn't wired up the
DataStoreUpdatercomponent, so we were just inserting flag updates directly in the memory store.With this in place, we can remove the streaming update suppression.