Skip to content

chore: resolve ValidChar function lint/compile warnings #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2023
Merged

chore: resolve ValidChar function lint/compile warnings #234

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c08af3
chore: resolve mac compile warning due to redundant check on ValidCha…
cwaldren-ld Sep 5, 2023
ba2b398
Update libs/common/src/config/app_info_builder.cpp
cwaldren-ld Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libs/common/src/config/app_info_builder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ tl::expected<std::string, Error> AppInfoBuilder::Tag::Build() const {
}

bool ValidChar(char c) {
if(c > 0 && c < 255) {
Copy link
Contributor Author

@cwaldren-ld cwaldren-ld Sep 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could put a static_assert(std::numeric_limits<char>::max() <= 0xFF). Is that too paranoid?

// The MSVC implementation of isalnum will assert if the number it outside
// its lookup table.
if (c > 0) {
// The MSVC implementation of isalnum will assert if the number is
// outside its lookup table (0-0xFF, inclusive.)
// iswalnum would not, but is less restrictive than desired.
return std::isalnum(c) != 0 || c == '-' || c == '.' || c == '_';
}
Expand Down