-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Add client support for streaming. #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
206501a
feat: Add client support for streaming.
kinyoklion 6f59220
Remove unused handler.
kinyoklion 1a1bd06
Tidy
kinyoklion 01ee650
Fix includes.
kinyoklion d19cec8
Merge branch 'main' into rlamb/basic-stream-and-flag-manager
kinyoklion 68b6f54
Remove unused headers.
kinyoklion 0d8981f
feat: Implement data source status. (#26)
kinyoklion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
libs/client-sdk/include/launchdarkly/client_side/connection.hpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| #pragma once | ||
|
|
||
| namespace launchdarkly::client_side { | ||
| // TODO: Can be moved to common. | ||
|
|
||
| /** | ||
| * Represents the connection of a listener. | ||
| * Disconnecting the connection will cause the listener to stop receiving | ||
| * events. | ||
| */ | ||
| class IConnection { | ||
| public: | ||
| /** | ||
| * Disconnect the listener and stop receiving events. | ||
| */ | ||
| virtual void Disconnect() = 0; | ||
|
|
||
| virtual ~IConnection() = default; | ||
| IConnection(IConnection const& item) = delete; | ||
| IConnection(IConnection&& item) = delete; | ||
| IConnection& operator=(IConnection const&) = delete; | ||
| IConnection& operator=(IConnection&&) = delete; | ||
|
|
||
| protected: | ||
| IConnection() = default; | ||
| }; | ||
| } // namespace launchdarkly::client_side |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The duplicate header + formatting lint are probably worth doing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deleted the headers, but my formatter doesn't seem to do anything.