fix: allow for installing only the client or server SDK independently #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
approved these changes
Oct 23, 2023
Merged
cwaldren-ld
pushed a commit
that referenced
this pull request
Oct 23, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-cpp-client: 3.2.1</summary> ## [3.2.1](launchdarkly-cpp-client-v3.2.0...launchdarkly-cpp-client-v3.2.1) (2023-10-23) ### Bug Fixes * allow for installing only the client or server SDK independently ([#269](#269)) ([fe08c3c](fe08c3c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cwaldren-ld
pushed a commit
that referenced
this pull request
Oct 25, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-cpp-server: 0.1.0</summary> ## 0.1.0 (2023-10-25) ### Features * server-side SDK ([#160](#160)) ([75eece3](75eece3)) ### Bug Fixes * allow for installing only the client or server SDK independently ([#269](#269)) ([fe08c3c](fe08c3c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest client release failed because I failed to consider that the
installstep currently requires all artifacts (both client, and now server) to be built. Since we usecmake --build . --target "$clientOrServer", it failed on the install step because server isn't built.This commit makes installation optional for either.