feat: refactor existing components into data system [2] #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
changed the title
kinyoklion
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the contents of
src/data_sources(polling + streaming implementations) into dedicated subdirectories of a new directory,data_components.The thousand-yard view is that we now have a larger abstraction (Data System) of which these components are a part of.
The objects in
data_componentscan be composed by SDK authors to create the Background Sync and Lazy Load data systems. Background Sync is the equivalent of streaming/polling, while Lazy Load operates against a database.The next PR will refactor the existing polling and streaming data sources to use these (now relocated) components.