refactor: remove obsolete server-related common lib components #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/common-lib-updates-datasystem
branch
2 times, most recently
from
3b9bad9 to
3b6c930
Compare
cwaldren-ld
force-pushed
the
cw/common-lib-updates-datasystem
branch
from
3b6c930 to
3ee4f86
Compare
cwaldren-ld
commented
Nov 22, 2023
| #include <launchdarkly/config/server_builders.hpp> | ||
| #include <launchdarkly/config/shared/sdks.hpp> | ||
| #include <launchdarkly/value.hpp> | ||
|
|
Contributor
Author
There was a problem hiding this comment.
(The removed tests are now in the server lib)
cwaldren-ld
commented
Nov 22, 2023
| @@ -1,7 +1,6 @@ | |||
| #include <gtest/gtest.h> | |||
|
|
|||
| #include <launchdarkly/config/client.hpp> | |||
Contributor
Author
There was a problem hiding this comment.
(The removed tests are now in the server lib)
keelerm84
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes obsolete server-related config from the
commonlib.