refactor: improve IDataSynchronizer's interface to expose IDestination #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
commented
Nov 22, 2023
| using T = std::decay_t<decltype(method_config)>; | ||
| if constexpr (std::is_same_v<T, | ||
| config::built::BackgroundSyncConfig:: | ||
| StreamingConfig>) { |
Contributor
Author
There was a problem hiding this comment.
Re-arranged the constructor arguments to follow our C++ standards.
cwaldren-ld
commented
Nov 22, 2023
| } | ||
|
|
||
| PollingDataSource::PollingDataSource( | ||
| boost::asio::any_io_executor const& ioc, |
Contributor
Author
There was a problem hiding this comment.
These changes follow from re-arranging the constructor args.
cwaldren-ld
commented
Nov 22, 2023
| return identity; | ||
| } | ||
|
|
||
| StreamingDataSource::StreamingDataSource( |
Contributor
Author
There was a problem hiding this comment.
Follows from re-arranging constructor args.
cwaldren-ld
commented
Nov 22, 2023
|
|
||
| [[nodiscard]] std::string const& Identity() const override; | ||
|
|
||
| private: |
Contributor
Author
There was a problem hiding this comment.
To match the constructor args, the members are re-arranged (so the order of initialization is visually correct.)
cwaldren-ld
changed the title
keelerm84
approved these changes
Nov 27, 2023
libs/server-sdk/src/data_systems/background_sync/sources/polling/polling_data_source.hpp
Outdated
Show resolved
Hide resolved
…ng/polling_data_source.hpp Co-authored-by: Matthew M. Keeler <keelerm84@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors
IDataSynchronizerto take anIDestinationand bootstrap data in itsStartAsyncmethod, rather than having an independentInitfunction.The addition of
IDestinationmakes the interface's purpose clearer.Before the destination was hidden - you'd only see it when constructing an implementation. Now it's clear that the
IDataSynchronizerputs data into theIDestination; no hidden dependency.It also doesn't make sense to "Init" an
IDataSynchronizerwith an SDKDataSet.The purpose of that call is to allow the synchronizer to inspect any existing data in possession by the SDK. The result of that inspection might mean an optimized fetch of initial data is possible (e.g. if there was an etag present in the initial data.)