feat: add Shutdown method to IDataSystem #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/datasystem-changes
branch
from
57a0c79 to
8fe2fc2
Compare
keelerm84
approved these changes
Nov 27, 2023
Base automatically changed from
cw/isynchronizer-changes
to
feat/data-system
November 27, 2023 17:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
Shutdownmethod toIDataSystem, which allows the system to stop any long-running asynchronous operations (such as streaming/polling mode.)Currently for the LazyLoad system, this is a no-op. In the future if we have some sort of "active cache eviction" on an interval, this would be used.