feat: implement JSON destination #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/json-destination-impl
branch
from
89b5e78 to
4b88673
Compare
cwaldren-ld
force-pushed
the
cw/json-destination-impl
branch
from
094a828 to
b347f33
Compare
Contributor
Author
|
Working on fixing the gMock segfault, but rest of PR is good to review. |
cwaldren-ld
commented
Nov 27, 2023
| lhs.serializedItem == rhs.serializedItem; | ||
| } | ||
|
|
||
| inline void PrintTo(SerializedItemDescriptor const& item, std::ostream* os) { |
Contributor
Author
There was a problem hiding this comment.
Used for pretty-er failures in google test.
kinyoklion
approved these changes
Nov 28, 2023
cwaldren-ld
force-pushed
the
cw/json-destination-impl
branch
from
237ca29 to
58122a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a JSON adapter (
JsonDestination) which is capable of accepting SDK in-memory models, transforming them into JSON, and passing them down to anISerializedDataDestination.In practice, this will be used to store serialized data in Redis.