fix: double variation was returning ints #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/fix-wrong-c-binding-double-variation
branch
from
a5c241c to
cf961d1
Compare
kinyoklion
approved these changes
Dec 13, 2023
Merged
cwaldren-ld
added a commit
that referenced
this pull request
Dec 13, 2023
🤖 I have created a release *beep* *boop*
---
<details><summary>launchdarkly-cpp-client: 3.3.1</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* launchdarkly-cpp-internal bumped from 0.5.0 to 0.5.1
* launchdarkly-cpp-common bumped from 1.1.0 to 1.2.0
</details>
<details><summary>launchdarkly-cpp-common: 1.2.0</summary>
##
[1.2.0](launchdarkly-cpp-common-v1.1.0...launchdarkly-cpp-common-v1.2.0)
(2023-12-13)
### Features
* add C bindings for getting log levels
([#334](#334))
([2b7f7d6](2b7f7d6))
</details>
<details><summary>launchdarkly-cpp-internal: 0.5.1</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* launchdarkly-cpp-common bumped from 1.1.0 to 1.2.0
</details>
<details><summary>launchdarkly-cpp-server: 3.0.1</summary>
##
[3.0.1](launchdarkly-cpp-server-v3.0.0...launchdarkly-cpp-server-v3.0.1)
(2023-12-13)
### Bug Fixes
* double variation was returning ints
([#335](#335))
([ef0559d](ef0559d))
### Dependencies
* The following workspace dependencies were updated
* dependencies
* launchdarkly-cpp-internal bumped from 0.5.0 to 0.5.1
* launchdarkly-cpp-common bumped from 1.1.0 to 1.2.0
</details>
<details><summary>launchdarkly-cpp-server-redis-source: 1.0.1</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* launchdarkly-cpp-server bumped from 3.0.0 to 3.0.1
</details>
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Casey Waldren <cwaldren@launchdarkly.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C bindings for
DoubleVariation/Detailwere returningintinstead ofdouble.Since this is totally wrong, I'm regarding it as a bugfix rather than as a breaking change.