Skip to content

fix: double variation was returning ints #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2023
Merged

fix: double variation was returning ints #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf961d1
fix: double variation was returning ints
cwaldren-ld Dec 13, 2023
bfc26d9
memory leak in test
cwaldren-ld Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/server-sdk/include/launchdarkly/server_side/bindings/c/sdk.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ LDServerSDK_IntVariationDetail(LDServerSDK sdk,
* @return The variation for the given context, or default_value if the
* flag is disabled in the LaunchDarkly control panel.
*/
LD_EXPORT(int)
LD_EXPORT(double)
LDServerSDK_DoubleVariation(LDServerSDK sdk,
LDContext context,
char const* flag_key,
Expand All @@ -322,7 +322,7 @@ LDServerSDK_DoubleVariation(LDServerSDK sdk,
* @return The variation for the given context, or default_value if the
* flag is disabled in the LaunchDarkly control panel.
*/
LD_EXPORT(int)
LD_EXPORT(double)
LDServerSDK_DoubleVariationDetail(LDServerSDK sdk,
LDContext context,
char const* flag_key,
Expand Down
7 changes: 3 additions & 4 deletions libs/server-sdk/src/bindings/c/sdk.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ struct Detail;

#define FROM_DETAIL(ptr) (reinterpret_cast<LDEvalDetail>(ptr))

#define TO_DATASOURCESTATUS(ptr) \
(reinterpret_cast<DataSourceStatus*>(ptr))
#define TO_DATASOURCESTATUS(ptr) (reinterpret_cast<DataSourceStatus*>(ptr))

#define FROM_DATASOURCESTATUS(ptr) \
(reinterpret_cast<LDServerDataSourceStatus>(ptr))
Expand Down Expand Up @@ -260,7 +259,7 @@ LDServerSDK_IntVariationDetail(LDServerSDK sdk,
});
}

LD_EXPORT(int)
LD_EXPORT(double)
LDServerSDK_DoubleVariation(LDServerSDK sdk,
LDContext context,
char const* flag_key,
Expand All @@ -273,7 +272,7 @@ LDServerSDK_DoubleVariation(LDServerSDK sdk,
default_value);
}

LD_EXPORT(int)
LD_EXPORT(double)
LDServerSDK_DoubleVariationDetail(LDServerSDK sdk,
LDContext context,
char const* flag_key,
Expand Down
3 changes: 2 additions & 1 deletion libs/server-sdk/tests/client_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ TEST_F(ClientTest, IntVariationDefaultPassesThrough) {

TEST_F(ClientTest, DoubleVariationDefaultPassesThrough) {
std::string const flag = "weight";
std::vector<double> values = {0.0, 12.0, 13.0, 24.0, 1000.0};
std::vector<double> values = {0.0, 0.0001, 0.5, 1.234,
12.0, 13.0, 24.0, 1000.0};
for (auto const& v : values) {
ASSERT_EQ(client_.DoubleVariation(context_, flag, v), v);
ASSERT_EQ(*client_.DoubleVariationDetail(context_, flag, v), v);
Expand Down
27 changes: 27 additions & 0 deletions libs/server-sdk/tests/server_c_bindings_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,3 +159,30 @@ TEST(ClientBindings, AllFlagsState) {
LDContext_Free(context);
LDServerSDK_Free(sdk);
}

TEST(ClientBindings, DoubleVariationPassesThroughDefault) {
LDServerConfigBuilder cfg_builder = LDServerConfigBuilder_New("sdk-123");

LDServerConfig config;
LDStatus status = LDServerConfigBuilder_Build(cfg_builder, &config);
ASSERT_TRUE(LDStatus_Ok(status));

LDServerSDK sdk = LDServerSDK_New(config);

LDContextBuilder ctx_builder = LDContextBuilder_New();
LDContextBuilder_AddKind(ctx_builder, "user", "shadow");
LDContext context = LDContextBuilder_Build(ctx_builder);

std::string const flag = "weight";
std::vector<double> values = {0.0, 0.0001, 0.5, 1.234,
12.9, 13.211, 24.0, 1000.0};
for (auto const& v : values) {
ASSERT_EQ(LDServerSDK_DoubleVariation(sdk, context, "weight", v), v);
ASSERT_EQ(LDServerSDK_DoubleVariationDetail(sdk, context, "weight", v,
LD_DISCARD_DETAIL),
v);
}

LDServerSDK_Free(sdk);
LDContext_Free(context);
}