Skip to content

fix: remove c++20 designated initializers #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2023
Merged

fix: remove c++20 designated initializers #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/common/include/network/detail/asio_requester.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ class FoxyClient
response_timeout_(response_timeout),
handler_(std::move(handler)),
session_(exec,
foxy::session_opts{.ssl_ctx = ToOptRef(ssl_context_.get()),
.timeout = connect_timeout_}),
foxy::session_opts{ToOptRef(ssl_context_.get()),
connect_timeout_}),
resp_() {}

void Run() {
Expand Down
5 changes: 2 additions & 3 deletions libs/server-sent-events/src/client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,8 @@ class FoxyClient : public Client,
req_(std::move(req)),
body_parser_(),
session_(executor,
foxy::session_opts{
.ssl_ctx = ToOptRef(ssl_context_),
.timeout = connect_timeout.value_or(kNoTimeout)}),
foxy::session_opts{ToOptRef(ssl_context_),
connect_timeout.value_or(kNoTimeout)}),
logger_(std::move(logger)) {
// SSE body will never end unless an error occurs, so we shouldn't set a
// size limit.
Expand Down