feat: add IBigSegmentStore interface + Redis and DynamoDB stores#536
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0082f6e. Configure here.
kinyoklion
requested changes
May 27, 2026
kinyoklion
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Ticket: SDK-2363 · Follows #534
Summary
Adds the public
IBigSegmentStoreinterface, theMembership/StoreMetadatavalue types, and concrete DynamoDB + Redis implementations. Schema strings match what the Relay Proxy writes.Design notes
synchronizedOnparsing. Stored as DynamoDB N / Redis string. Both stores reject malformed values (non-numeric strings, wrong DynamoDB attribute type) rather than silently returning 0, matching the existingdynamodb_source.cpprow validation.Not in scope
BigSegmentsBuilderconfig plumbing.BigSegmentStoreWrapper(LRU cache + staleness polling) and the hashing path.rules.cppbig-segments TODO.Test plan
Membershipunit tests pass.RedisBigSegmentStoreintegration tests pass against Redis 7 (docker).DynamoDBBigSegmentStoreintegration tests pass against DynamoDB Local.Note
Medium Risk
New external-store read path for segment targeting with strict schema validation; not yet wired into evaluation, so production flag behavior is unchanged until follow-up PRs land.
Overview
Introduces a Big Segments persistent store surface for the server SDK: public
IBigSegmentStore, inlineMembership/StoreMetadata, and read-only Redis and DynamoDB backends that follow Relay’s key/schema layout (prefix scoping, include/exclude refs, sync metadata).Stores perform point lookups by opaque context hash, build membership via
Membership::FromSegmentRefs(inclusion wins on overlap), and return errors on malformed DynamoDB attribute types or non-numeric sync timestamps instead of silent empty/zero results. Config, caching wrapper, hashing, and flag evaluation wiring are not included in this change.Integration tests cover membership/metadata behavior, prefix isolation, and error paths against Redis and DynamoDB Local.
Reviewed by Cursor Bugbot for commit d2622d9. Bugbot is set up for automated code reviews on this repo. Configure here.