chore: make clang-tidy only run on files in PR & make cancellable #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
You know what would be cool? If the action didn't download boost, run cmake, do all that stuff.. and then check if any files have changed!. But that is what it does. Still, this should be an improvement. (52 seconds on this PR that didn't change any cpp files.) |
cwaldren-ld
force-pushed
the
cw/clang-tidy-improvements
branch
from
056b5a2 to
984f72b
Compare
This was referenced May 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains two improvements to address the slowness of the linter:
I had (2) disabled because I wanted it to scan the whole repo (it was introduced after there was already code in the repo.) I think we can change that now. I should probably have changed that a couple days ago but I forgot about it.