feat: add error.hpp and tl::expected library #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/error-codes
branch
from
b63b2ad to
861a608
Compare
cwaldren-ld
commented
Mar 30, 2023
| enum class Error : std::uint32_t { | ||
| KReserved1 = 0, | ||
| KReserved2 = 1, | ||
| /* Common lib errors: 2-99 */ |
Contributor
Author
There was a problem hiding this comment.
In case we decide to do:
- some kind of casting to
LDBoolean(0/1) - Generic success
- Generic failure
I've just reserved the first two values.
cwaldren-ld
commented
Mar 30, 2023
| /* Client-side errors: 100-199 */ | ||
| /* Server-side errors: 200-299 */ | ||
|
|
||
| kMax = std::numeric_limits<std::uint32_t>::max() |
Contributor
Author
There was a problem hiding this comment.
kMax is just here to make us remember to do something similar in C, to help with ABI stability as we add new values in the future.
kinyoklion
approved these changes
Mar 31, 2023
This was referenced May 8, 2023
This was referenced May 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in the
tl::expectedlibrary for error handling. The idea is that we can return value types, as well as an error code from functions. I believe something similar is slated forstd::.It has nice things like
mapbuilt in.I'm not 100% all in on having a single
Errorenum, I just thought it'd be simpler to ensure unique unique error codes from a C standpoint.