chore: require Python 3.10 to align with latest OpenFeature and LaunchDarkly SDKs - #16
Merged
Merged
Conversation
…ly SDKs Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
jsonbailey
approved these changes
Jul 27, 2026
jsonbailey
marked this pull request as ready for review
July 27, 2026 15:59
joker23
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This example app declared
python = "^3.9", which silently held it back to old transitive SDK versions. Bothopenfeature-sdk0.10.0 andlaunchdarkly-server-sdk9.16.1 declarerequires_python >= 3.10, so Poetry had to resolve downwards to satisfy the 3.9 floor:The provider this app demonstrates (
openfeature-python-server) already requirespython = "^3.10", so the^3.9floor here was inconsistent with the library it exists to showcase. Python 3.9 is also past end-of-life..github/workflows/ci.ymlpinnedpython-version: 3.9, which would now fail dependency resolution, so it moves to'3.10'(quoted so YAML doesn't parse it as the float3.1).How to test
Verified locally:
poetry installnow resolves OpenFeature 0.10.0 + LaunchDarkly 9.16.1, andmain.pyconnects to LaunchDarkly and evaluates the flag through the provider successfully.Risks / limitations
Anyone running this example on Python 3.9 will need to upgrade to 3.10+. That is unavoidable — the current SDK releases do not support 3.9.
Link to Devin session: https://app.devin.ai/sessions/62983b2a41614cf2a9e97f2760512fe1
Note
Low Risk
Version and CI pin changes only; the main operational note is that anyone still on Python 3.9 must upgrade to run the example.
Overview
Raises the example app’s Python floor from 3.9 to 3.10 in
pyproject.toml(python = "^3.10"), aligning with the OpenFeature/LaunchDarkly stacks that no longer support 3.9 and allowing Poetry to pull current SDK releases instead of older transitive pins.CI is updated to match:
.github/workflows/ci.ymlnow installs Python'3.10'(quoted) instead of3.9, sopoetry installin the workflow succeeds under the new constraint.Reviewed by Cursor Bugbot for commit eb11875. Bugbot is set up for automated code reviews on this repo. Configure here.