chore: default LAUNCHDARKLY_FLAG_KEY to sample-feature - #13
Merged
Conversation
Co-Authored-By: jbailey@launchdarkly.com <accounts@sidewaysgravity.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Author
|
@cursor review |
kinyoklion
approved these changes
Aug 3, 2026
kinyoklion
marked this pull request as ready for review
August 3, 2026 16:01
jsonbailey
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The README states that a boolean flag of
sample-featureis assumed whenLAUNCHDARKLY_FLAG_KEYis unset, butmain.rbread the variable without a default, so running the example without it printed*** The feature flag evaluates to false.(empty key, always the default value). This matches the behavior of the sibling examples (hello-ruby,hello-openfeature-node-server).Dependency check (weekly SDK-freshness pass)
No dependency changes needed:
launchdarkly-openfeature-server-sdk '~> 0.2'— latest is 0.2.0; already satisfied.launchdarkly-server-sdk(unconstrained) — resolves to latest 8.14.0.Gemfile.lock, sobundle installalready picks up the latest compatible gems.-W:deprecatedrun produced no warnings).How to test
Verified against a real SDK key both with and without
LAUNCHDARKLY_FLAG_KEYset.Risks
None; console-only example, one-line change.
Link to Devin session: https://app.devin.ai/sessions/99fa63dd93664185808e8b7ba127af91
Requested by: @jsonbailey
Note
Low Risk
Console-only sample app; single-line env default with no security or data impact.
Overview
Aligns runtime behavior with the README by defaulting
LAUNCHDARKLY_FLAG_KEYtosample-featurewhen the env var is missing.Previously the script read the variable with no fallback, so an unset key produced an empty flag name in the output and always evaluated the default boolean. With the default, running only with
LAUNCHDARKLY_SDK_KEYevaluates the documentedsample-featureflag.Reviewed by Cursor Bugbot for commit db65f31. Bugbot is set up for automated code reviews on this repo. Configure here.