-
Notifications
You must be signed in to change notification settings - Fork 68
prepare 2.8.0 release #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix TypeScript def for event name and add documentation
replace Base64 dependency with a package that has a lowercase name
override short default timeout in one EventSource polyfill
…vent-streaming allow streaming mode to be decoupled from event subscription
…er-bootstrap fire change event when updating flags after bootstrap from localstorage
use deep compare to decide whether a flag value has changed
apucacao
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[2.8.0] - 2018-12-03
Added:
client.setStreaming()method, or the equivalent booleanstreamingproperty in the client configuration. If you set this tofalse, the client will not open a streaming connection even if you subscribe to change events (you might want to do this if, for instance, you just want to be notified when the client gets new flag values due to having switched users). If you set it totrue, the client will open a streaming connection regardless of whether you subscribe to change events or not (the flag values will simply be updated in the background). If you don't set it either way then the default behavior still applies, i.e. the client opens a streaming connection if and only if you subscribe to change events.Fixed:
on('change', ...)one or more times, it will not close the connection until you calloff()for all of your event listeners. Previously, it was closing the connection wheneveroff('change')was called, even if you still had a listener for'change:specific-flag-key'.changeevent was using a regular Javascript===comparison, so it could incorrectly decide that a flag had changed if its value was a JSON object or an array. This has been fixed to use deep equality checking for object and array values.