Skip to content

chore: Set up iota to describe steps instead of using ints #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbolson merged 2 commits into from
Apr 3, 2024
Merged

chore: Set up iota to describe steps instead of using ints #124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56e55ef
Set up iota to describe steps instead of using ints
Apr 3, 2024
fd2c05d
Merge branch 'main' into more-explicit-setup-steps
Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion internal/quickstart/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,14 @@ const (
defaultEnvKey = "test"
)

const (
_ = iota
stepCreateFlag
stepChooseSDK
stepShowSDKInstructions
stepToggleFlag
)

// ContainerModel is a high level container model that controls the nested models wher each
// represents a step in the quick-start flow.
type ContainerModel struct {
Expand Down Expand Up @@ -57,7 +65,7 @@ func (m ContainerModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
cmd = tea.Quit
case key.Matches(msg, keys.Back):
// if showing SDK instructions, let the user go back to choose a different SDK
if m.currentStep == 3 {
if m.currentStep == stepShowSDKInstructions {

@dbolson dbolson Apr 3, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 is wrong. It should be 3 which is the show SDK instructions page.

@k3llymariee k3llymariee Apr 3, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay the iotas were nice for this

m.currentStep -= 1
m.currentModel = NewChooseSDKModel(m.sdk.index)
cmd = m.currentModel.Init()
Expand Down