Skip to content

feat: Clear view when quitting setup #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbolson merged 1 commit into from
Apr 4, 2024
Merged

feat: Clear view when quitting setup #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/quickstart/choose_sdk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ type chooseSDKModel struct {

func NewChooseSDKModel(selectedIndex int) tea.Model {
l := list.New(sdksToItems(), sdkDelegate{}, 30, 14)
l.Title = "Select your SDK:\n\n" // extra newlines to show pagination
l.Title = "Select your SDK:\n"

@dbolson dbolson Apr 4, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be consistent with the other views.

// reset title styles
l.Styles.Title = lipgloss.NewStyle()
l.Styles.TitleBar = lipgloss.NewStyle()
Expand Down
4 changes: 4 additions & 0 deletions internal/quickstart/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@ func (m ContainerModel) View() string {
return out
}

if m.quitting {

@dbolson dbolson Apr 4, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes after the error check since that may force-quit the app.

return ""
}

return out
}

Expand Down