Convert neovim config to Lua - #3
Merged
Merged
Conversation
Since LSP configuration was already in Lua I decided to "convert" the rest of my neovim configuration as well. I stumbled upon the https://github.com/brainfucksec/neovim-lua repository which I took as a base and have applied most of my previous plugins and configs that were not present out of the box. I've left some out for now intentionally and might add them back in if I miss them. I had also thought about switching from vim-plug to packer.nvim to manage plugins so that was achieved here as well. The statusline plugin changed from lualine to feline which I had also considered testing. I still left my old configs in place so either can be installed. I'll get rid of the old stuff when I feel comfortable in doing so. In general the new configs seem less convoluted than the old.
This was referenced Oct 22, 2025
laurigates
added a commit
that referenced
this pull request
Jun 29, 2026
…newcomers) (#286) ## Summary Follow-up #3 of 3 from PR #283. The project pin `.claude/settings.json` `enabledPlugins` had drifted to **40 keys** vs the **44-key** canonical marketplace set, silently disabling 4 newcomers in web/remote sessions. `enabledPlugins` merges via **whole-map replacement** — the project map REPLACES the global map where `~/.claude` is unavailable (web/remote/CI), so a plugin absent from the project pin is *disabled* there regardless of global state. An exhaustive pin must therefore list the full set. ## Changes Added the 4 missing marketplace plugins with **dotfiles-appropriate states** (intentionally diverging from the global overlay, which has all four `true`): | Plugin | State | Rationale | |---|---|---| | `comfyui-plugin` | `false` | domain-irrelevant to dotfiles | | `foundryvtt-plugin` | `false` | domain-irrelevant to dotfiles | | `software-design-plugin` | `false` | not needed here | | `session-plugin` | `true` | broadly useful (global = true) | ## Verification - `jq empty .claude/settings.json` → valid - `jq '.enabledPlugins | length'` → **44** - `./tests/test-claude-plugin-references.sh` → **4/4** (Check B green — all 4 newcomers exist in the marketplace) - `mise run test:plugin-refs` → green; pre-commit (incl. `check-json`) clean 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
laurigates
added a commit
that referenced
this pull request
Jul 12, 2026
…tection to #3 (#321) Two corrections to `git-hazards.md`, both earned in a session that recovered an auto-closed PR (laurigates/claude-plugins#2049). ## Hazard #1 — the "immune to drift" claim was wrong It claimed `git merge-tree --write-tree` containment is *"immune to squash + drift"*. The squash half is right; **the drift half is not.** Once `main` moves on over the same files, merging an already-merged branch back would re-introduce its older versions, so the trees differ and merge-tree reports **not contained** for work that fully landed. It misreported three merged branches as unmerged during the audit. Fixed by reordering the checks by real authority and adding `git cherry`: | Check | Strength | |---|---| | `gh pr list --state all --head <branch>` | **Authoritative** — a MERGED PR settles it | | `git cherry main <branch>` | Marks `-` on patch-equivalent commits — survives squash **and** cherry-pick, ignores drift | | `git merge-tree` containment | A match proves containment; **a non-match proves nothing** | ## Hazard #3 — the auto-close is silent, and only a sweep finds it No failed check, no notification; the PR list just looks one shorter. #2049 sat stranded for a day, and the sweep afterwards found **26 dead branches** — two carrying work that never had a PR opened *at all*. An event handler on `pull_request: closed` cannot cover this: by the time it fires the base ref is deleted (the reopen window is gone), and it is structurally blind to never-PR'd branches. A scheduled sweep is the only thing that works — `claude-plugins scripts/check-stranded-work.sh` (laurigates/claude-plugins#2056). Also records the **accident-vs-decision discriminator**: a closed-unmerged PR whose base ref **404s** was auto-closed; one whose base ref is **alive** was closed by a human. 11 of the 26 were deliberate closes and must not be resurrected. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Ap1qbGLEkvv1gaG5hSasps Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since LSP configuration was already in Lua I decided to "convert" the
rest of my neovim configuration as well. I stumbled upon the
https://github.com/brainfucksec/neovim-lua repository which I took as a
base and have applied most of my previous plugins and configs that were
not present out of the box. I've left some out for now intentionally and
might add them back in if I miss them.
I had also thought about switching from vim-plug to packer.nvim to
manage plugins so that was achieved here as well. The statusline plugin
changed from lualine to feline which I had also considered testing.
I still left my old configs in place so either can be installed. I'll
get rid of the old stuff when I feel comfortable in doing so. In general
the new configs seem less convoluted than the old.