Skip to content

Fix pager position#1115

Merged
banana-three-join merged 3 commits into
layer5io:masterfrom
banana-three-join:bug/banana-three-join/fix-pager-position
Jun 23, 2026
Merged

Fix pager position#1115
banana-three-join merged 3 commits into
layer5io:masterfrom
banana-three-join:bug/banana-three-join/fix-pager-position

Conversation

@banana-three-join

Copy link
Copy Markdown
Contributor

Notes for Reviewers

This PR fixes #1114

image

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>
Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorganizes layout files by moving the related-reading.html, video-section-related.html, and recent-discussions.html partials inside the main content container, while removing them from layouts/docs/single.html. The review feedback correctly identifies that because recent-discussions.html is only active when .Section is "kanvas", rendering it unconditionally inside a styled div introduces unwanted vertical whitespace on other pages. It is recommended to wrap these blocks in a conditional check and replace the inline margin styles with a Bootstrap utility class like mt-4 for better maintainability.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread layouts/_default/content.html Outdated
Comment thread layouts/docs/list.html Outdated
Comment thread layouts/docs/rest-apis.html Outdated
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.6.3
Preview removed because the pull request was closed.
2026-06-23 14:21 UTC

@banana-three-join banana-three-join changed the title Bug/banana three join/fix pager position Fix pager position Jun 22, 2026
Comment thread layouts/docs/rest-apis.html Outdated
Comment thread layouts/docs/list.html Outdated
Comment thread layouts/_default/content.html Outdated
Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>
@banana-three-join banana-three-join merged commit f130809 into layer5io:master Jun 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Related Reading" is misplaced

2 participants