Skip to content

fix: update wait for pages deployment - #1183

Merged
banana-three-join merged 1 commit into
layer5io:masterfrom
banana-three-join:fix/banana-three-join/update-preview-deployment
Aug 4, 2026
Merged

fix: update wait for pages deployment#1183
banana-three-join merged 1 commit into
layer5io:masterfrom
banana-three-join:fix/banana-three-join/update-preview-deployment

Conversation

@banana-three-join

@banana-three-join banana-three-join commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

Summary by CodeRabbit

  • Documentation
    • Updated preview deployment comments to clarify that the preview link may require waiting and refreshing while deployment is in progress.
    • Added a link to the deployment workflow for tracking progress.

Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>
@banana-three-join
banana-three-join merged commit d199576 into layer5io:master Aug 4, 2026
3 of 4 checks passed
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8d3f0b63-7bd5-4ae4-8f4a-adaff1ebc88f

📥 Commits

Reviewing files that changed from the base of the PR and between c6a7d5a and 07ffd94.

📒 Files selected for processing (1)
  • .github/workflows/deploy-docs-preview.yml

📝 Walkthrough

Walkthrough

The docs preview workflow no longer waits for GitHub Pages deployment completion. The pull request comment now warns about possible delays and links to the Pages deployment workflow.

Changes

Docs preview deployment

Layer / File(s) Summary
Deployment continuation and preview notice
.github/workflows/deploy-docs-preview.yml
The workflow continues without waiting for deployment completion. The preview comment explains that the URL may require waiting and refreshing, and links to the Pages deployment workflow.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • layer5io/docs#1181: Modifies the same preview deployment workflow and its deployment wait behavior.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🚀 Preview deployment: https://docs.layer5.io/pr-preview/pr-1183/

Note: Preview may take a moment (GitHub Pages deployment in progress). Please wait and refresh. Track deployment here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant