fix(terminal): prevent long URL clipping and improve layout responsiveness - #8021
Conversation
…eness Signed-off-by: Mayank Sharma <sharmamayank01010@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates the animated steps layout for responsive sizing and spacing. It also moves terminal wrapper styles into the styled component, wraps long text, and constrains code content within the terminal boundary. ChangesTerminal layout updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The terminal now wraps long URLs and uses responsive sizing to prevent horizontal clipping. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
src/components/Animated-steps-list/AnimatedStepsList.style.jsParsing error: The keyword 'import' is reserved src/components/Terminal/Terminal.style.jsParsing error: The keyword 'import' is reserved Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@dhruveshmishra Review this |
|
🚀 Preview deployment: https://layer5.io/pr-preview/pr-8021/ |
dhruveshmishra
left a comment
There was a problem hiding this comment.
@MAYANKSHARMA01010 The spacing between the sections seems a bit too tight. Could you increase the spacing slightly to make the layout look cleaner and more balanced?
dhruveshmishra
left a comment
There was a problem hiding this comment.
src/components/Terminal/Terminal.style.js
@MAYANKSHARMA01010 There are quite a few changes in Terminal.style.js that seem to be related only to formatting/spacing and pressing Enter, which aren't necessary for this PR. Could you please keep only the changes required for the issue and revert the unrelated formatting changes? This will keep the PR focused and easier to review.
This PR addresses and fixes #8008 where long URLs (such as
https://github.com/meshery/meshery/tree/v0.6.0/install/deployment_yamls/k8s) in the Meshery installation terminal on the Getting Started page were getting cut off horizontally on desktop viewports.Root Cause
<pre>block inTerminal.style.jswas usingwrap-word: normal;(an invalid CSS property) withoutoverflow-wrap: anywhere;, causing long strings without whitespace to overflow and be clipped byoverflow-x: hidden.max-widthmedia queries and large fixed margins (margin-left: 150px) that either caused off-screen overflow on certain screens or left an unused void on the right side on wide desktop screens.Changes Made
overflow-wrap: anywhere;andoverflow-wrap: break-word;inTerminal.style.jsso continuous strings wrap gracefully on narrow viewports without clipping.AnimatedStepsList.style.js, added responsive extension using CSSclamp()on viewportsflex: 1; min-width: 0; max-width: 100%) and balanced spacing (margin-left: 36px).Visual Proof
Checklist
npm run checklint)git commit -s)Summary by CodeRabbit