Fix CSS-in-JS warning for msOverflowStyle#1572
Merged
Merged
Conversation
Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request standardizes the CSS properties used to hide scrollbars across the ModalBody and RecentActivityGrid components by updating the syntax to camelCase. A review comment suggests refactoring this duplicated styling logic into a shared utility or theme mixin to improve maintainability and ensure consistency across the codebase.
Comment on lines
124
to
+128
| scrollbarWidth: 'none', | ||
| msOverflowStyle: 'none', | ||
| '&::-webkit-scrollbar': { | ||
| display: 'none' | ||
| }, | ||
| '-ms-overflow-style': 'none' | ||
| } |
Contributor
There was a problem hiding this comment.
The CSS pattern for hiding scrollbars is duplicated in both ModalBody and RecentActivityGrid (in src/custom/Workspaces/styles.tsx). To improve maintainability and ensure consistency across the project, consider refactoring these properties into a shared utility object or a theme mixin.
Example:
export const hideScrollbar = {
scrollbarWidth: 'none',
msOverflowStyle: 'none',
'&::-webkit-scrollbar': {
display: 'none'
}
};
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
Description
This PR fixes a CSS-in-JS warning caused by using the kebab-case vendor-prefixed property -ms-overflow-style inside the ModalBody styled component.
Changes
Replaced:
With:
msOverflowStyle: 'none'Result
Removes the React/MUI CSS-in-JS warning.
Preserves the intended scrollbar hiding behavior for legacy Microsoft browsers.
Keeps existing ::-webkit-scrollbar and scrollbarWidth behavior unchanged.
This PR fixes #1571
Signed commits