Skip to content

Fix CSS-in-JS warning for msOverflowStyle#1572

Merged
arjunmehta-git merged 1 commit into
layer5io:masterfrom
Katotodan:fix/kebab-case
May 21, 2026
Merged

Fix CSS-in-JS warning for msOverflowStyle#1572
arjunmehta-git merged 1 commit into
layer5io:masterfrom
Katotodan:fix/kebab-case

Conversation

@Katotodan
Copy link
Copy Markdown
Member

Notes for Reviewers

Description

This PR fixes a CSS-in-JS warning caused by using the kebab-case vendor-prefixed property -ms-overflow-style inside the ModalBody styled component.

Changes

Replaced:

'-ms-overflow-style': 'none'

With:

msOverflowStyle: 'none'

Result

Removes the React/MUI CSS-in-JS warning.
Preserves the intended scrollbar hiding behavior for legacy Microsoft browsers.
Keeps existing ::-webkit-scrollbar and scrollbarWidth behavior unchanged.

This PR fixes #1571

Signed commits

  • Yes, I signed my commits.

Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
Copy link
Copy Markdown
Contributor

@arjunmehta-git arjunmehta-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@arjunmehta-git arjunmehta-git merged commit dde4428 into layer5io:master May 21, 2026
5 checks passed
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request standardizes the CSS properties used to hide scrollbars across the ModalBody and RecentActivityGrid components by updating the syntax to camelCase. A review comment suggests refactoring this duplicated styling logic into a shared utility or theme mixin to improve maintainability and ensure consistency across the codebase.

Comment on lines 124 to +128
scrollbarWidth: 'none',
msOverflowStyle: 'none',
'&::-webkit-scrollbar': {
display: 'none'
},
'-ms-overflow-style': 'none'
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The CSS pattern for hiding scrollbars is duplicated in both ModalBody and RecentActivityGrid (in src/custom/Workspaces/styles.tsx). To improve maintainability and ensure consistency across the project, consider refactoring these properties into a shared utility object or a theme mixin.

Example:

export const hideScrollbar = {
  scrollbarWidth: 'none',
  msOverflowStyle: 'none',
  '&::-webkit-scrollbar': {
    display: 'none'
  }
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] CSS-in-JS warning caused by kebab-case vendor-prefixed property

2 participants