Skip to content

Fix CSS-in-JS warning for msOverflowStyle #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arjunmehta-git merged 1 commit into from
May 21, 2026
Merged

Fix CSS-in-JS warning for msOverflowStyle #1572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/custom/Modal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,10 @@ export const ModalBody = styled(Paper)(({ theme }) => ({
overflowY: 'auto',
height: '100%',
scrollbarWidth: 'none',
msOverflowStyle: 'none',
'&::-webkit-scrollbar': {
display: 'none'
},
'-ms-overflow-style': 'none'
}
Comment on lines 124 to +128
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The CSS pattern for hiding scrollbars is duplicated in both ModalBody and RecentActivityGrid (in src/custom/Workspaces/styles.tsx). To improve maintainability and ensure consistency across the project, consider refactoring these properties into a shared utility object or a theme mixin.

Example:

export const hideScrollbar = {
  scrollbarWidth: 'none',
  msOverflowStyle: 'none',
  '&::-webkit-scrollbar': {
    display: 'none'
  }
};

}));

const StyledFooter = styled('div', {
Expand Down
4 changes: 2 additions & 2 deletions src/custom/Workspaces/styles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,10 +399,10 @@ export const RecentActivityGrid = styled(Grid2)({
maxHeight: '14.5rem',
overflowY: 'scroll',
scrollbarWidth: 'none',
msOverflowStyle: 'none',
'&::-webkit-scrollbar': {
display: 'none'
},
'-ms-overflow-style': 'none'
}
});

export const DateGrid = styled(Grid2)(({ theme }) => ({
Expand Down
Loading