chore(deps): bump @meshery/schemas to 1.3.1#1587
Conversation
Picks up the product-neutral `CURRENT_ORG_KEY` rename in the upstream schemas package: `Layer5-Current-Orgid` -> `X-Current-Orgid`. Sistent re-exports the constant through `src/schemas/index.tsx` (pass-through); no source change required here. Coordinated with: - meshery/schemas v1.3.1 (published) - meshery/meshery-cloud (PR open) - meshery/meshery (follow-up) - layer5labs/meshery-extensions (follow-up) Verification: - npm run build: green (cjs + esm + dts) - dist artifacts carry "X-Current-Orgid"; no "Layer5-Current-Orgid" - npm test: 273/273 passing Signed-off-by: miacycle <184569369+miacycle@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request updates @meshery/schemas to version 1.3.1 and rearranges the @swc/core and @swc/jest dependencies in package.json. The reviewer noted that the upgraded @meshery/schemas introduces peer dependencies on @reduxjs/toolkit and react-redux. Because @meshery/schemas is configured under noExternal in tsup.config.ts, this could lead to bundle bloat or duplicate runtime instances of Redux. It is recommended to either externalize these dependencies or ensure tree-shaking successfully discards them.
| "@eslint/eslintrc": "^3.3.5", | ||
| "@eslint/js": "^10.0.1", | ||
| "@meshery/schemas": "1.2.22", | ||
| "@meshery/schemas": "1.3.1", |
There was a problem hiding this comment.
The upgraded @meshery/schemas (v1.3.1) introduces peer dependencies on @reduxjs/toolkit and react-redux.
Since @meshery/schemas is configured under noExternal in tsup.config.ts, its code is bundled directly into the distributed artifacts of @sistent/sistent. If any of the imported or re-exported modules from @meshery/schemas reference @reduxjs/toolkit or react-redux, tsup will bundle these large libraries into the final output because they are not listed in external or peerDependencies of @sistent/sistent.
To avoid bundle bloat or duplicate instances of Redux/Toolkit at runtime, please verify if these dependencies are being bundled. If they are, consider:
- Adding
@reduxjs/toolkitandreact-reduxto theexternalarray intsup.config.tsand declaring them aspeerDependenciesinpackage.json. - Or ensuring that only the specific, non-Redux constants/schemas are imported/exported from
@meshery/schemasso that tree-shaking can successfully discard the Redux-related code during the build.
References
- If a component is exported from a main entry point, its dependencies should be defined as required peer dependencies rather than optional ones. This prevents build-time resolution failures for consumers who may not use the specific component but still have their bundlers attempt to resolve the static imports.
There was a problem hiding this comment.
Pull request overview
Bumps @meshery/schemas from 1.2.22 to 1.3.1, allowing Sistent’s existing schema/API utility re-exports to pick up the upstream product-neutral header constant rename without local source changes.
Changes:
- Updates the pinned
@meshery/schemasdevDependency. - Refreshes
package-lock.jsonto resolve@meshery/schemas@1.3.1. - Reorders existing
@swc/*devDependencies alphabetically inpackage.json.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
package.json |
Updates @meshery/schemas and keeps devDependencies ordered. |
package-lock.json |
Locks @meshery/schemas to version 1.3.1 with updated tarball metadata. |
Summary
Bumps the pinned
@meshery/schemasdep from1.2.22to1.3.1. Picks up the product-neutralCURRENT_ORG_KEYrename in the upstream schemas package:Layer5-Current-Orgid->X-Current-OrgidLayer5-Current-Org-Name->X-Current-Org-NameLayer5-Program->X-ProgramSistent re-exports the constant through
src/schemas/index.tsx(pass-through); no source change required.Lockstep cluster
meshery/schemasv1.3.1 - publishedmeshery/meshery-cloud- PR #5403 openmeshery/meshery- follow-uplayer5labs/meshery-extensions- follow-upTest plan
npm run build: green (cjs + esm + dts)dist/index.{js,mjs}) carry"X-Current-Orgid"; zero"Layer5-Current-Orgid"referencesnpm test: 273/273 passing