Skip to content

chore(deps): bump @meshery/schemas to 1.3.1#1587

Merged
CodeAhmedJamil merged 1 commit into
masterfrom
chore/bump-meshery-schemas-1.3.1
May 28, 2026
Merged

chore(deps): bump @meshery/schemas to 1.3.1#1587
CodeAhmedJamil merged 1 commit into
masterfrom
chore/bump-meshery-schemas-1.3.1

Conversation

@hamza-mohd
Copy link
Copy Markdown
Contributor

Summary

Bumps the pinned @meshery/schemas dep from 1.2.22 to 1.3.1. Picks up the product-neutral CURRENT_ORG_KEY rename in the upstream schemas package:

  • Layer5-Current-Orgid -> X-Current-Orgid
  • Layer5-Current-Org-Name -> X-Current-Org-Name
  • Layer5-Program -> X-Program

Sistent re-exports the constant through src/schemas/index.tsx (pass-through); no source change required.

Lockstep cluster

Test plan

  • npm run build: green (cjs + esm + dts)
  • dist artifacts (dist/index.{js,mjs}) carry "X-Current-Orgid"; zero "Layer5-Current-Orgid" references
  • npm test: 273/273 passing

Picks up the product-neutral `CURRENT_ORG_KEY` rename in the upstream
schemas package: `Layer5-Current-Orgid` -> `X-Current-Orgid`. Sistent
re-exports the constant through `src/schemas/index.tsx` (pass-through);
no source change required here.

Coordinated with:
- meshery/schemas v1.3.1 (published)
- meshery/meshery-cloud (PR open)
- meshery/meshery (follow-up)
- layer5labs/meshery-extensions (follow-up)

Verification:
- npm run build: green (cjs + esm + dts)
- dist artifacts carry "X-Current-Orgid"; no "Layer5-Current-Orgid"
- npm test: 273/273 passing

Signed-off-by: miacycle <184569369+miacycle@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 28, 2026 05:20
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates @meshery/schemas to version 1.3.1 and rearranges the @swc/core and @swc/jest dependencies in package.json. The reviewer noted that the upgraded @meshery/schemas introduces peer dependencies on @reduxjs/toolkit and react-redux. Because @meshery/schemas is configured under noExternal in tsup.config.ts, this could lead to bundle bloat or duplicate runtime instances of Redux. It is recommended to either externalize these dependencies or ensure tree-shaking successfully discards them.

Comment thread package.json
"@eslint/eslintrc": "^3.3.5",
"@eslint/js": "^10.0.1",
"@meshery/schemas": "1.2.22",
"@meshery/schemas": "1.3.1",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The upgraded @meshery/schemas (v1.3.1) introduces peer dependencies on @reduxjs/toolkit and react-redux.

Since @meshery/schemas is configured under noExternal in tsup.config.ts, its code is bundled directly into the distributed artifacts of @sistent/sistent. If any of the imported or re-exported modules from @meshery/schemas reference @reduxjs/toolkit or react-redux, tsup will bundle these large libraries into the final output because they are not listed in external or peerDependencies of @sistent/sistent.

To avoid bundle bloat or duplicate instances of Redux/Toolkit at runtime, please verify if these dependencies are being bundled. If they are, consider:

  1. Adding @reduxjs/toolkit and react-redux to the external array in tsup.config.ts and declaring them as peerDependencies in package.json.
  2. Or ensuring that only the specific, non-Redux constants/schemas are imported/exported from @meshery/schemas so that tree-shaking can successfully discard the Redux-related code during the build.
References
  1. If a component is exported from a main entry point, its dependencies should be defined as required peer dependencies rather than optional ones. This prevents build-time resolution failures for consumers who may not use the specific component but still have their bundlers attempt to resolve the static imports.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps @meshery/schemas from 1.2.22 to 1.3.1, allowing Sistent’s existing schema/API utility re-exports to pick up the upstream product-neutral header constant rename without local source changes.

Changes:

  • Updates the pinned @meshery/schemas devDependency.
  • Refreshes package-lock.json to resolve @meshery/schemas@1.3.1.
  • Reorders existing @swc/* devDependencies alphabetically in package.json.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
package.json Updates @meshery/schemas and keeps devDependencies ordered.
package-lock.json Locks @meshery/schemas to version 1.3.1 with updated tarball metadata.

@CodeAhmedJamil CodeAhmedJamil merged commit 7d3f01f into master May 28, 2026
6 checks passed
@CodeAhmedJamil CodeAhmedJamil deleted the chore/bump-meshery-schemas-1.3.1 branch May 28, 2026 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants