Skip to content

chore(deps): bump @meshery/schemas to 1.3.1 #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeAhmedJamil merged 1 commit into from
May 28, 2026
Merged

chore(deps): bump @meshery/schemas to 1.3.1 #1587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"@emotion/cache": "^11.14.0",
"@eslint/eslintrc": "^3.3.5",
"@eslint/js": "^10.0.1",
"@meshery/schemas": "1.2.22",
"@meshery/schemas": "1.3.1",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The upgraded @meshery/schemas (v1.3.1) introduces peer dependencies on @reduxjs/toolkit and react-redux.

Since @meshery/schemas is configured under noExternal in tsup.config.ts, its code is bundled directly into the distributed artifacts of @sistent/sistent. If any of the imported or re-exported modules from @meshery/schemas reference @reduxjs/toolkit or react-redux, tsup will bundle these large libraries into the final output because they are not listed in external or peerDependencies of @sistent/sistent.

To avoid bundle bloat or duplicate instances of Redux/Toolkit at runtime, please verify if these dependencies are being bundled. If they are, consider:

  1. Adding @reduxjs/toolkit and react-redux to the external array in tsup.config.ts and declaring them as peerDependencies in package.json.
  2. Or ensuring that only the specific, non-Redux constants/schemas are imported/exported from @meshery/schemas so that tree-shaking can successfully discard the Redux-related code during the build.
References
  1. If a component is exported from a main entry point, its dependencies should be defined as required peer dependencies rather than optional ones. This prevents build-time resolution failures for consumers who may not use the specific component but still have their bundlers attempt to resolve the static imports.

"@mui/icons-material": "^9.0.0",
"@mui/material": "^9.0.0",
"@mui/system": "^9.0.0",
Expand All @@ -55,6 +55,8 @@
"@rjsf/mui": "^6.5.2",
"@rjsf/utils": "^6.5.2",
"@rjsf/validator-ajv8": "^6.5.2",
"@swc/core": "^1.10.12",
"@swc/jest": "^0.2.37",
"@testing-library/dom": "^10.4.1",
"@testing-library/react": "^16.3.2",
"@types/jest": "^30.0.0",
Expand Down Expand Up @@ -85,8 +87,6 @@
"rehype-raw": "^7.0.0",
"remark-gfm": "^4.0.1",
"rollup": "^4.60.2",
"@swc/core": "^1.10.12",
"@swc/jest": "^0.2.37",
"tsup": "^8.5.1",
"typescript": "^6.0.3",
"xstate": "^5.31.0"
Expand Down
Loading