Skip to content

fix: export ActionButton component from sistent - #1782

Merged
banana-three-join merged 2 commits into
layer5io:masterfrom
KhushamBansal:fix/action-button-dts-export
Aug 7, 2026
Merged

fix: export ActionButton component from sistent#1782
banana-three-join merged 2 commits into
layer5io:masterfrom
KhushamBansal:fix/action-button-dts-export

Conversation

@KhushamBansal

@KhushamBansal KhushamBansal commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

Summary by CodeRabbit

  • New Features
    • Added the ActionButton component to the package’s public exports for use in applications.
    • Added public access to ActionButtonProps and Option types, improving support for type-safe customization and configuration.

Signed-off-by: KhushamBansal <kbkhushambansal@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ea9d8ce0-cdf4-4044-a42d-1d3e4d0a79fc

📥 Commits

Reviewing files that changed from the base of the PR and between d0e7370 and 8fb3846.

📒 Files selected for processing (3)
  • src/custom/ActionButton/ActionButton.tsx
  • src/custom/ActionButton/index.tsx
  • src/index.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/index.tsx

📝 Walkthrough

Walkthrough

The package now publicly exports ActionButton, ActionButtonProps, and Option through the package entry point. Option is now an exported interface.

Changes

ActionButton export

Layer / File(s) Summary
Package entry point export
src/custom/ActionButton/ActionButton.tsx, src/custom/ActionButton/index.tsx, src/index.tsx
Exports the Option interface, re-exports ActionButtonProps and Option, and exposes ActionButton with both types from the package entry point.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: rishiraj38

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: exporting the ActionButton component from sistent.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Katotodan Katotodan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this export to src/index.tsx solves the problem, but I think the code could be cleaner and better scoped if we added the export to src/custom/index.ts instead (and still keep the export from src/custom/index.tsx).

Currently, it's exported from src/custom/index.tsx. If we add the export to src/custom/index.ts, I believe it should still work while keeping the change more localized and organized.

I could be mistaken, though.

@ishwar170695 ishwar170695 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This follows the existing explicit export pattern used in src/index.tsx for components affected by the declaration bundling issue.

@ishwar170695

Copy link
Copy Markdown

Adding this export to src/index.tsx solves the problem, but I think the code could be cleaner and better scoped if we added the export to src/custom/index.ts instead (and still keep the export from src/custom/index.tsx).

Currently, it's exported from src/custom/index.tsx. If we add the export to src/custom/index.ts, I believe it should still work while keeping the change more localized and organized.

I could be mistaken, though.

I think the explicit export in src/index.tsx is intentional here. The existing comments indicate it's a workaround for rollup-plugin-dts dropping declarations behind export * from './custom', so I'd lean toward keeping it consistent with the existing pattern.

@banana-three-join banana-three-join left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it also needs the typing exported

Signed-off-by: KhushamBansal <kbkhushambansal@gmail.com>
@KhushamBansal

Copy link
Copy Markdown
Contributor Author

I believe it also needs the typing exported

@banana-three-join Thanks for reviewing. I have updated the PR.

@banana-three-join banana-three-join left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty! LGTM

@banana-three-join
banana-three-join merged commit 9a475ad into layer5io:master Aug 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants