fix: export ActionButton component from sistent - #1782
Conversation
Signed-off-by: KhushamBansal <kbkhushambansal@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe package now publicly exports ChangesActionButton export
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Katotodan
left a comment
There was a problem hiding this comment.
Adding this export to src/index.tsx solves the problem, but I think the code could be cleaner and better scoped if we added the export to src/custom/index.ts instead (and still keep the export from src/custom/index.tsx).
Currently, it's exported from src/custom/index.tsx. If we add the export to src/custom/index.ts, I believe it should still work while keeping the change more localized and organized.
I could be mistaken, though.
ishwar170695
left a comment
There was a problem hiding this comment.
LGTM. This follows the existing explicit export pattern used in src/index.tsx for components affected by the declaration bundling issue.
I think the explicit export in |
banana-three-join
left a comment
There was a problem hiding this comment.
I believe it also needs the typing exported
Signed-off-by: KhushamBansal <kbkhushambansal@gmail.com>
@banana-three-join Thanks for reviewing. I have updated the PR. |
Notes for Reviewers
This PR fixes #
Signed commits
Summary by CodeRabbit
ActionButtoncomponent to the package’s public exports for use in applications.ActionButtonPropsandOptiontypes, improving support for type-safe customization and configuration.