Add methods that takes percentage parameters #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now possible to user ‘%’ characters. ex: view.pin.top().left(25%).width(25%).height(100%) * top(_ percent: Percent) * left(_ percent: Percent) * bottom(_ percent: Percent) * right(_ percent: Percent) * hCenter(_ percent: Percent) * vCenter(_ percent: Percent) Plus: * Implement hCenter() & vCenter() * Implement margin(_ vertical: CGFloat, _ horizontal: CGFloat) & margin(_ top: CGFloat, _ horizontal: CGFloat, _ bottom: CGFloat) * Add more unit tests * Removed few forced optionals * Removed deprecated UIView+PinLayout extension.
|
Nice les % ! |
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 93.54% 93.93% +0.38%
==========================================
Files 15 14 -1
Lines 2417 2605 +188
==========================================
+ Hits 2261 2447 +186
- Misses 156 158 +2
Continue to review full report at Codecov.
|
Member
Author
|
@hugomirego oui je trouve aussi 😄 |
added 2 commits
June 2, 2017 11:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to user ‘%’ characters.
ex:
view.pin.top().left(25%).width(25%).height(100%)
Plus: