Skip to content

Conversation

@krystophny
Copy link
Collaborator

Summary

  • flip the 3D X-axis tick marks and labels so they render beneath the axis in device space
  • skip drawing the legacy 2D tick labels when 3D plots are active while still rendering the axis title/x/y labels

Testing

  • make verify-artifacts

https://chatgpt.com/codex/tasks/task_e_68cd9f2942248324b0b3feb6167d67cd

@krystophny krystophny requested a review from Copilot September 19, 2025 18:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes two issues with 3D plotting: corrects the orientation of X-axis tick marks and labels to render beneath the axis in device space, and eliminates duplicate 2D tick labels when 3D plots are active while preserving axis titles.

  • Improved 3D axis tick positioning by considering Y-span direction to determine proper downward orientation in device space
  • Replaced legacy 2D axis drawing with dedicated label-only rendering for 3D plots to avoid duplicate tick marks
  • Added proper handling of optional string parameters when drawing axis labels in 3D mode

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/plotting/fortplot_3d_axes.f90 Modified tick positioning logic to account for Y-span direction and ensure proper downward orientation
src/backends/raster/fortplot_raster.f90 Replaced 2D axis drawing with label-only rendering for 3D plots and added safe string handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@krystophny krystophny merged commit 12478a5 into main Sep 19, 2025
2 checks passed
@krystophny krystophny deleted the codex/fix-horizontal-axis-tick-position-and-labels branch September 19, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants